[vlc-devel] [PATCH 1/3] [RFC] vlc_es: add the original chroma

[Steve Lhomme]

On Tue, Jul 12, 2016 at 5:03 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le 2016-07-12 16:59, Steve Lhomme a écrit :
>>
>> This is needed when using opaque chroma formats. The vout doesn't know the
>> pixel format that is intended to be decoded and so we can't decide for
>> 8/10/12/16 bits rendering. The same goes for YUV vs RGB or for 4:2:0
>> vs 4:2:2.
>
>
> What the hell is an "original chroma"? I understand original codec, though
> that seems quite useless in video output, or really for anything other than
> informational purpose. In VLC, a chroma is a pixel format, and I fail to
> grasp the concept of an original pixel format.
>
> For hardware, the pixel format is unknown; it's most often a vendor-specific
> hardware-specific tiling format that VLC knows nothing and should know
> nothing about.

Look at 3/3 for the reason why it's needed. I used the name chroma
because that's the same use as i_chroma next to it.

This could also replace VLC_CODEC_VDPAU_VIDEO_444 /
VLC_CODEC_VDPAU_VIDEO_422 / VLC_CODEC_VDPAU_VIDEO_420 with just one
VLC_CODEC_VDPAU_OPAQUE and the original format the decoder wanted to
use instead of the opaque.

>> ---
>>  include/vlc_es.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/vlc_es.h b/include/vlc_es.h
>> index a933b11..6465921 100644
>> --- a/include/vlc_es.h
>> +++ b/include/vlc_es.h
>> @@ -284,6 +284,7 @@ typedef enum video_chroma_location_t
>>  struct video_format_t
>>  {
>>      vlc_fourcc_t i_chroma;                               /**<
>> picture chroma */
>> +    vlc_fourcc_t i_original_chroma;       /**< original for opaque
>> hw chroma */
>>
>>      unsigned int i_width;                                 /**<
>> picture width */
>>      unsigned int i_height;                               /**<
>> picture height */
>
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel