[vlc-devel] [PATCH 0/3] beauty lies in the eyes of the adaptive

Filip Roséen filip at videolabs.io
Wed Jul 13 22:02:44 CEST 2016

By default, {:adaptive-width,:adaptive-height} was previously set to
{480,360} (respectively).

Given the behavior of `class RepresentationSelector`, this would in
turn mean that if a stream with those exact meassurements is found -
it will unconditionally be used.

What is done in this patch-batch?

    - the default values are now 0 (zero) for both variables

    - class RepresentationSelector will only use {width,height} if the
      variable in question is not 0 (zero).

    - a longtext option has been added to explain the semantics of 

What could be done in the future?

Currently, as was in the past, a stream is considered a viable
alternative if, and only if, the dimensions of it exactly matches

I find this a little restrictive, and would instead propose a weighted
selection that finds a stream that has dimensions /close/ to the desired

Filip Roséen (3):
  demux/adaptive: changed default-values for adaptive-{width,height}
  demux/adaptive: only use width/height for selection if explicitly set
  demux/adaptive: add longtext to adaptive-{width,height} option

 modules/demux/adaptive/adaptive.cpp                      | 10 ++++++++--
 modules/demux/adaptive/logic/Representationselectors.cpp | 13 +++++++++++--
 2 files changed, 19 insertions(+), 4 deletions(-)


More information about the vlc-devel mailing list