[vlc-devel] [PATCH v2] video_output: add support for Flaschen-Taschen screen protocol

François Revol revol at free.fr
Sun Jul 17 19:22:04 CEST 2016


On 13/07/2016 02:15, François Revol wrote:
> cf.
> https://github.com/hzeller/flaschen-taschen/blob/master/doc/protocols.md
> 
> * TODO implement offset_{x,y,z} ? (mostly useful for games though)
> * TODO try to fix aspect ratio (it's 1:1 always)
> * TODO limit the framerate? It's meant to be used over a LAN, but still...


> +    fd = net_ConnectDgram( vd, display, port, -1, IPPROTO_UDP );
> +    free(display);
> +
> +    if( fd == -1 )
> +    {
> +        msg_Err( vd,
> +                 "cannot create UDP socket for %s port %u",
> +                 display, port );
> +        free(sys);

I'll fix this use-after-free of display in v3.

I'll also fix some other things, and assign the msghdr struct member by
member.

Any other comment before I send the v3?

Hopefully it'll be correct this time :D

François.


More information about the vlc-devel mailing list