[vlc-devel] [PATCH 00/18] Giving the context-menu in Qt some love

[Filip Roséen]

Primarily I planned on fixing #17184 and #10051, but I decided to do
some minor clean-up of other parts since I was jumping around in the
relevant directories in either case (to see how things fit together).

Tickets fixed:

    - https://trac.videolan.org/vlc/ticket/17184
    - https://trac.videolan.org/vlc/ticket/10051


I am really not sure about the last patch (marked RFC), and I would be
very thankful for some feedback on the matter, as such; below is a
happy (ascii) hippo:

              
          .-''''-. _    
         ('    '  '0)-/)
         '..____..:    \._
           \u  u (        '-..------._
           |     /      :   '.        '--.
          .nn_nn/ (      :   '            '\
         ( '' '' /      ;     .             \
          ''----' "\          :            : '.
                 .'/                           '.
                / /                             '.
               /_|       )                     .\|
                 |      /\                     . '
                 '--.__|  '--._  ,            /
                              /'-,          .'
                             /   |        _.' 
                            (____\       /    
                                  \      \    
                                   '-'-'-'    

       src: http://www.ascii-art.de/ascii/ghi/hippo.txt
                                                    
                                      
Now that I actually look at the hippo in my terminal he/she might not
be happy at all.. looks kinda, borderline, mad; but let us pretend
that it is a happy one!


Filip Roséen (18):
  gui/qt: remove unused macros
  gui/qt: add struct vlc_playlist_locker
  gui/qt: prevent potential deadlock in PLModel::dropAppendCopy
  gui/qt: use vlc_playlist_locker in PLModel::flags
  gui/qt: use vlc_playlist_locker in PLModel::dropMove
  gui/qt: use vlc_playlist_locker in PLModel::isLeaf
  gui/qt: use vlc_playlist_locker in PLModel::processItemAppend
  gui/qt: use vlc_playlist_locker in PLModel::rebuild
  gui/qt: use vlc_playlist_locker in PLModel::sort
  gui/qt: use vlc_playlist_locker in PLModel::filter
  gui/qt: use vlc_playlist_locker in PLModel::createNode
  gui/qt: use vlc_playlist_locker in PLModel::renameNode
  gui/qt: use vlc_playlist_locker in PLModel::action
  gui/qt: use vlc_playlist_locker in PLModel::activateItem
  gui/qt: use vlc_playlist_locker in MessagesDialog::updatePLTree
  gui/qt: fix #17184 (missing entries in context-menu)
  gui/qt: fix #10051 (unable to create playlist directory)
  include/playlist: add helper to lock a playlist

 include/vlc_playlist.h                             |  25 ++
 .../gui/qt/components/playlist/playlist_model.cpp  | 307 ++++++++++++---------
 modules/gui/qt/dialogs/messages.cpp                |   9 +-
 modules/gui/qt/qt.hpp                              |   2 -
 4 files changed, 204 insertions(+), 139 deletions(-)

-- 
2.9.0