[vlc-devel] [RFC PATCH 01/12] modules: add module_need_next and vlc_module_load_next

[Thomas Guillem]

On Tue, Jul 19, 2016, at 21:05, Rémi Denis-Courmont wrote:
> Le tiistaina 19. heinäkuuta 2016, 20.16.08 EEST Jean-Baptiste Kempf a
> écrit :
> > On 19 Jul, Rémi Denis-Courmont wrote :
> > > This is very ugly and I still completely fail to see the point. VLC module
> > 
> > Didn't we mention several times that we needed to get rid of the audio
> > a52|dts filters to move them to decoders, so that we can remove liba52,
> > libdts (and make elenril happy) and have passthru of more formats?
> 
> Yes. But I don´t see why that requires huge changes to module loader,
> which is 
> the bulk of the series. Indeed loss of format is handled in audio output,
> and 
> is essentially the exact same scenario.

What do you mean by loss of format ?

By the way, the big difference between a decoder and a converter is that
the converter setup the output format from the Open callback (so,
fallback works naturally). For decoders, it's different. The output
format can be setup from Open but will, most of the time, be setup after
the first calls of pf_decode (so when the decoder is already opened).
Indeed, the decoder may have not enough informations in the Open
callback to setup the output. That is why we need this fallback
mechanism.

I already tried to solve it the other way around, forcing a packetizer,
and having all the informations we need to setup an output format in the
Open callback of the decoder.

> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel