[vlc-devel] [RFC PATCH 01/12] modules: add module_need_next and vlc_module_load_next

[Thomas Guillem]

On Wed, Jul 20, 2016, at 11:32, Rémi Denis-Courmont wrote:
> Le 2016-07-20 09:51, Thomas Guillem a écrit :
> > On Tue, Jul 19, 2016, at 21:05, Rémi Denis-Courmont wrote:
> >> Le tiistaina 19. heinäkuuta 2016, 20.16.08 EEST Jean-Baptiste Kempf 
> >> a
> >> écrit :
> >> > On 19 Jul, Rémi Denis-Courmont wrote :
> >> > > This is very ugly and I still completely fail to see the point. 
> >> VLC module
> >> >
> >> > Didn't we mention several times that we needed to get rid of the 
> >> audio
> >> > a52|dts filters to move them to decoders, so that we can remove 
> >> liba52,
> >> > libdts (and make elenril happy) and have passthru of more formats?
> >>
> >> Yes. But I don´t see why that requires huge changes to module 
> >> loader,
> >> which is
> >> the bulk of the series. Indeed loss of format is handled in audio 
> >> output,
> >> and
> >> is essentially the exact same scenario.
> >
> > What do you mean by loss of format ?
> 
> I meant "format loss" from audio outputs.
> 
> > By the way, the big difference between a decoder and a converter is 
> > that
> > the converter setup the output format from the Open callback (so,
> > fallback works naturally). For decoders, it's different.
> 
> Asynchronous failure means format loss. Synchronous failure means 
> unsupported format.
> 
> You can't have asynchronous failure for unsupported format, since you'd 
> either end up in an infinite loop, or breaking format loss handling. 

An infinite loop, where ?

You mean the DecoderThread that continue to pull blocks and release them
when the module is in an error state ? If so, this is already happening
currently. I would also like to solve this issue by notifying the core
that an ES track should be disabled.

By the way, it's currently possible in avcodec: having an asynchronous
failure for unsupported format.

> That's been discussed a number of times.
> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel