[vlc-devel] [PATCH 16/18] gui/qt: fix #17184 (missing entries in context-menu)

[Jean-Baptiste Kempf]

On 21 Jul, Filip Roséen wrote :
> On 2016-07-21 17:59, Jean-Baptiste Kempf wrote:
> > >  bool PLModel::isSupportedAction( actions action, const QModelIndex
> > > &index ) const
> > >  {
> > > -    if( !index.isValid() )
> > > -        return false;
> > > +    vlc_playlist_locker pl_lock ( THEPL );
> > 
> > Why remove the call to isValid here?
> 
> Because "index.isValid()" yields false if you right-click on an empty area
> (ie. not on an entity within the (gui-)playlist, a QModelIndex is only valid
> if it refers to an actual item within the list.

Right... I'm quite sure I did not that for fun :)

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device