[vlc-devel] [PATCH] flaschen: implement --flaschen-offset-{x, y, z}

[François Revol]

On 27/07/2016 14:31, Filip Roséen wrote:
> 
> 
> On 16/07/27 14:22, François Revol wrote:
> 
>>      @@ -66,6 +75,9 @@ vlc_module_begin ()
>>           add_string( "flaschen-display", NULL, T_FLDISPLAY, LT_FLDISPLAY, true )
>>           add_integer("flaschen-width", 25, T_WIDTH, LT_WIDTH, false)
>>           add_integer("flaschen-height", 20, T_HEIGHT, LT_HEIGHT, false)
>>      +    add_integer("flaschen-offset-x", 0, T_OFFSET_X, LT_OFFSET_X, false)
>>      +    add_integer("flaschen-offset-y", 0, T_OFFSET_Y, LT_OFFSET_Y, false)
>>      +    add_integer("flaschen-offset-z", 0, T_OFFSET_Z, LT_OFFSET_Z, false)
>>       vlc_module_end ()
> 
> I would argue that `flaschen-offset-{x,y,z}` are advanced options.
> 

Right, I didn't notice the last argument last time. Although I didn't
really see any difference in the settings GUI.
flaschen-display OTOH should probably not be advanced as it's mandatory.

François.