[vlc-devel] [PATCH 2/2] copy: only copy the src_pitch pixels on each line not the whole width

Steve Lhomme robux4 at gmail.com
Thu Jul 28 17:19:48 CEST 2016


On Thu, Jul 28, 2016 at 4:44 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le 2016-07-28 15:03, Steve Lhomme a écrit :
>>
>> On Thu, Jul 28, 2016 at 2:58 PM, Jean-Baptiste Kempf <jb at videolan.org>
>> wrote:
>>>
>>> How does that work if you have an offset?
>>
>>
>> The pitch includes the offset data. They are copied as well. It
>> doesn't change from before. Pixels outside of the i_visible_pitch are
>> also copied. That changes from before where some optimization was
>> possible.
>
>
> I think the question is, how does it work if the offsets are different in
> input and output formats?

It works regardless of the offset because the pitch is independent
from it. It's only based on the size of buffer allocated by the
software or hardware. The offset and visible area are only applied in
other parts of the code.

> (Not sure if it even works properly in other chroma conversions though)
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list