[vlc-devel] [PATCH] input/access: fix argument to stream_FilterChainNew

Filip Roséen filip at atch.se
Fri Jul 29 01:55:51 CEST 2016


The patch which this email is a reply to is utterly wrong for several
reasons:

  1. The arguments to stream_FilterChainNew are correct, this patch should
     never have seen the light of day (I kept it as a reminder to always
     double check the implementation before writing something).

		 I guess I should also try to remember to check what I am about to send
     with `git send-email`.

  2. I forgot to double check that the directory which the below linked
     patch ended up with was actually only containing that one before hitting
     enter.

     - https://mailman.videolan.org/pipermail/vlc-devel/2016-July/108824.html

To compensate for the noise, here's a (sad) ascii-snail (since my mind seems
very very slow this evening)!


                    / /
                    L_L_
                   /    \
                   |00  |       _______
                   |_.  |      /  ___  \
                   |  \ |     /  /   \  \
                   |    |_____\  \_  /  /
                    \          \____/  /_____
                     \ _______________/______\............


On 16/07/29 01:49, Filip Roséen wrote:

>       src/input/access.c | 2 +-
>       1 file changed, 1 insertion(+), 1 deletion(-)
>      diff --git a/src/input/access.c b/src/input/access.c
>      index e7df2ee..3c032d3 100644
>      --- a/src/input/access.c
>      +++ b/src/input/access.c
>      @@ -408,7 +408,7 @@ stream_t *stream_AccessNew(vlc_object_t *parent, input_thread_t *input,
>           if (sys->access->pf_read != NULL)
>           {
>               s->pf_read = AStreamReadStream;
>      -        cachename = "prefetch,cache_read";
>      +        cachename = "prefetch:cache_read";
>           }
>           else
>           {
>      -- 
>      2.9.0
> 
     
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160729/70d9c7fe/attachment.html>


More information about the vlc-devel mailing list