[vlc-devel] [PATCH] WGL: OpenGL module for Windows

[Adrien Maglo]

Le 08/06/2016 15:00, Denis Charmet a écrit :
> Hi,

Hi,

>> +static int Open(vlc_object_t *object)
>> +{
>> +    vlc_gl_t *gl = (vlc_gl_t *)object;
>> +    vout_display_sys_t *sys;
>> +
>> +    /* Allocate structure */
>> +    gl->sys = sys = calloc(1, sizeof(*sys));
>> +    if (!sys)
>> +        return VLC_ENOMEM;
>> +
>> +    /* Process selected GPU affinity */
>> +    int nVidiaAffinity = var_InheritInteger(gl, "gpu-affinity");
>> +    if (nVidiaAffinity >= 0) CreateGPUAffinityDC(gl, nVidiaAffinity);
>
> If you flag the destruction in Close() shouldn't you do it here too?

Yes indeed, there is an issue. Actually, there should be no flag in Close().

Thanks!


-- 
Adrien