[vlc-devel] [PATCH] input: check the pf_demux existance on the actual demuxer not the demux filter

[Rémi Denis-Courmont]

Le 2016-06-22 18:50, Steve Lhomme a écrit :
> On Wed, Jun 22, 2016 at 5:00 PM, Rémi Denis-Courmont 
> <remi at remlab.net> wrote:
>> Le 2016-06-22 10:54, Steve Lhomme a écrit :
>>>
>>> ---
>>>  src/input/input.c | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>>
>> This makes no sense whatsoever.
>
> The issue is this assert:
>
> assert( in->p_demux->pf_demux != NULL || !in->b_can_pace_control );
>
> When used with a demux filter only the second test is meaningful 
> since
> pf_demux is never NULL for a demux filter. Do we want to assert for
> all demuxers that answer true to DEMUX_CAN_CONTROL_PACE ?

This paragraph also makes no logical sense.

-- 
Rémi Denis-Courmont
http://www.remlab.net/