[vlc-devel] [RFC 00/38] removal of implicit/explicit use of abort

[Filip Roséen]

Some of these patches are really easy to review, while others require some more
work in order to really make sure that cases are handled correctly.

The problem which these patches all (try) to solve is relatively easy; we do
not want to invoke `abort`, instead we rather have the potential error
propogate up until the relevant part of the code.

All of these were written in states where I was either too tired, or too sick,
to work on things I would have liked to have worked on; as such I really want
to emphazise that there might be _really_ stupid mistakes present - and if so I
apologize.

As most often, here's some ASCII-art:


        ,'";-------------------;"`.
        ;[]; ................. ;[];
        ;  ; ................. ;  ;
        ;  ; ......V.L.C...... ;  ;
        ;  ; ....OPERATION.... ;  ;
        ;  ; .C L E A N - U P. ;  ;
        ;  ; ................. ;  ;
        ;  ; ................. ;  ;
        ;  `.                 ,'  ;
        ;    """""""""""""""""    ;
        ;    ,-------------.---.  ;
        ;    ;  ;"";       ;   ;  ;
        ;    ;  ;  ;       ;   ;  ;
        ;    ;  ;  ;       ;   ;  ;
        ;//||;  ;  ;       ;   ;||;
        ;\\||;  ;__;       ;   ;\/;
         `. _;          _  ;  _;  ;
           " """"""""""" """"" """


Filip Roséen (38):
  include/vlc_common: mark x{malloc,realloc,calloc,strdup} as deprecated
  access/live555: replaced usage of abort
  access/dtv: removed usage of abort
  demux/nuv: removed usage of abort
  codec/lpcm: remove usage of abort
  demux/flac: replaced usage of xmalloc
  demux/ty: removed usage of xmalloc
  codec/flac: removed usage of xmalloc
  demux/stl: replaced usage of x{malloc,calloc}
  demux/stl.c: fix potential off-by-one read
  audio_output/winstore: removed usage of abort
  demux/avformat: removed usage of xcalloc
  access/bluray: replaced usage of xmalloc
  demux/avi: removed usage of xmalloc
  lua/libs: removed usage of xmalloc
  demux/vobsub: replaced usage of x{realloc,malloc}
  demux/oggseek: replaced usage of xmalloc
  mux/avi: replaces usage of xrealloc
  codec/lpcm: replaces usage of xmalloc
  demux/ogg: replaces usage of xmalloc
  packetizer/mpeg4video: replaced usage of xmalloc
  packetizer/mpeg4video: use calloc instead of malloc+memset
  access/vcd: replaced usage of xmalloc
  demux/avformat: replaced usage of xmalloc
  codec/subsdec: replaced usage of xmalloc
  access/archive/access: replaced usage of xmalloc
  video_output/direct_draw: replaced usage of xmalloc
  codec/speex: replaced usage of xmalloc
  access_output/http: removed usage of xmalloc
  audio_filter/audibargraph_a: replaced usage of xmalloc
  access/zip: replaced usage of xstrdup
  demux/real: removed usage of xcalloc
  config/core: replaced usage of x{malloc,strdup}
  demux/avi: replaced usage of xcalloc
  gui/ncurses: replaced usage of xmalloc
  stream_out/mosaic_bridge: replaced usage of x{realloc,malloc}
  stream_out/bridge: replaced usage of x{malloc,realloc}
  access/vcd: replaced usage of xrealloc

 include/vlc_common.h                    |  8 +--
 modules/access/archive/access.c         | 12 ++++-
 modules/access/bluray.c                 |  6 ++-
 modules/access/dtv/bdagraph.cpp         |  2 +-
 modules/access/live555.cpp              | 22 ++++++---
 modules/access/vcd/vcd.c                | 17 +++++--
 modules/access/zip/zipaccess.c          |  9 +++-
 modules/access_output/http.c            |  8 ++-
 modules/audio_filter/audiobargraph_a.c  |  6 ++-
 modules/audio_output/winstore.c         | 32 +++++++++---
 modules/codec/flac.c                    |  7 ++-
 modules/codec/lpcm.c                    | 86 ++++++++++++++++++---------------
 modules/codec/speex.c                   | 27 +++++++++--
 modules/codec/subsdec.c                 |  9 +++-
 modules/demux/avformat/demux.c          | 29 +++++++++--
 modules/demux/avi/libavi.c              | 63 ++++++++++++++++++------
 modules/demux/flac.c                    | 20 ++++++--
 modules/demux/nuv.c                     |  7 ++-
 modules/demux/ogg.c                     |  6 ++-
 modules/demux/oggseek.c                 |  4 +-
 modules/demux/real.c                    | 12 ++---
 modules/demux/stl.c                     | 73 ++++++++++++++++------------
 modules/demux/ty.c                      | 19 ++++++--
 modules/demux/vobsub.c                  | 33 +++++++++++--
 modules/gui/ncurses.c                   |  6 ++-
 modules/lua/libs/net.c                  | 11 ++++-
 modules/mux/avi.c                       | 15 +++++-
 modules/packetizer/mpeg4video.c         | 12 +++--
 modules/stream_out/bridge.c             | 21 ++++++--
 modules/stream_out/mosaic_bridge.c      | 23 ++++++---
 modules/video_output/win32/directdraw.c | 12 ++++-
 src/config/core.c                       | 50 ++++++++++++++-----
 32 files changed, 490 insertions(+), 177 deletions(-)

-- 
2.9.0