[vlc-devel] [PATCH 00/11] Initial cleaning of demux/mkv

Filip Roséen filip at videolabs.io
Wed Mar 2 18:04:41 CET 2016

During the last few days I have been working on demux/mkv, primarily to clean
it up but also to squeeze out more performance where applicable. The patches in
this patch-tree are isolated enough so that they can be reviewed in an easy

There are many more patches coming up, though I will need to split them up
into easily managable chunks, as well as reordering them so that it actually
makes sense to apply them one by one.

This patch-tree can be thought of as the initial cleaning, mostly blowing away
dust before whipping out the sandpaper to really fix it up.

Filip Roséen (11):
  demux/mkv: added warning regarding undefined-behavior
  demux/mkv: cleaned `chapters.{cpp,hpp}`
  demux/mkv: replaced manual memory-management with `std::vector` in
  demux/mkv: Introduced MKV_CHECKED_PTR_DECL
  demux/mkv: `MKV_CHECKED_PTR_DECL` introduced to `matroska_segment.cpp`
  demux/mkv: removed unnecessary dynamic memory allocations
  demux/mkv: removed manual memory management from Tags + SimpleTags
  demux/mkv: replaced (manual) linked-list with std::vector in
  demux/mkv: Added error diagnostic if i_track does not match seekpoint
  demux/mkv: removed unnecessary memory-allocation in
  demux/mkv: Reimplemented MkvTree and moved it to `Util.hpp`

 modules/demux/mkv/Ebml_parser.cpp            |   2 +-
 modules/demux/mkv/chapters.cpp               |  70 ++--
 modules/demux/mkv/chapters.hpp               |   3 +
 modules/demux/mkv/demux.cpp                  |  14 +-
 modules/demux/mkv/matroska_segment.cpp       | 589 +++++++++++----------------
 modules/demux/mkv/matroska_segment.hpp       |  34 +-
 modules/demux/mkv/matroska_segment_parse.cpp |  39 +-
 modules/demux/mkv/mkv.cpp                    |  20 +-
 modules/demux/mkv/mkv.hpp                    |   1 +
 modules/demux/mkv/util.cpp                   |  42 ++
 modules/demux/mkv/util.hpp                   |   4 +
 11 files changed, 367 insertions(+), 451 deletions(-)


More information about the vlc-devel mailing list