[vlc-devel] [PATCH 07/11] demux/mkv: removed manual memory management from Tags + SimpleTags

Filip Roséen filip at videolabs.io
Thu Mar 3 15:38:33 CET 2016


Thanks to *Hugo Beauzée-Luyseen* it was discovered that `SimpleTag::b_default`
is no longer used; we write to it once but effectively discard the value.

The attached patch removes the data-member completely instead of having it
lingering behind (looking like it might be used uninitalized, even though we
never read it).

Once again, thanks Hugo!

           )
          (.)
          .|.
          l8J
          | |
      _.--| |--._
   .-';  ;`-'& ; `&.
  & &  ;  &   ; ;   \
  \      ;    &   &_/
   F"""---...---"""J
   | | | | | | | | |
   J | | | | | | | F
    `---.|.|.|.---'

/* ascii-cake for Hugo */
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160303/40d9f719/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-demux-mkv-removed-manual-memory-management-from-Tags.patch
Type: text/x-diff
Size: 17287 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160303/40d9f719/attachment.patch>


More information about the vlc-devel mailing list