[vlc-devel] [RFC, PATCH 1/6] demux/mkv: Added EbmlTypeDispatcher (including changes to Makefile.am)

Filip Roséen filip at videolabs.io
Fri Mar 4 11:27:46 CET 2016

Hmm, I don't have that line of code in the codebase anymore - I will however
resubmit this patch-batch due to major cleanup that have changed things (and as
such the patch no longer apply).

Though I tested the patches (in this thread) on a fresh git pull before I sent
it to `vlc-devel`, but the dangerous c-style cast is probably to blame for not
resulting in a compile error.

I have replaced as many c-style casts as I can find in earlier patches, before I
got bitten by a really nasty bug where a variable was name `ctime` prior to the
modification, and I changed it to another name (forgetting to change one
instance of where `ctime` was used).

The problem? A c-style cast such as `uint32( ctime )` was used later, and
everything compiled fine because `time.h` is implicitly included. The compiler
then happily converted the _function pointer_ to an `uint32`.

The new patch-block should fix such hard-to-track bugs since the appropriate c++
casts have replaced the c-style ones.



On 16/03/04 11:16, Francois Cartegnie wrote:

> Le 03/03/2016 13:30, Filip Roséen a écrit :
> >       E_CASE( KaxAudioChannels, achan ) {
> >         vars.p_tk->fmt.audio.i_channels = uint8( chan );
> >       }
> I'm not sure what is the issue with KaxParsing,
> but I doubt this patch compiles with the above typo :p
> Francois
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160304/f1b50e07/attachment.html>

More information about the vlc-devel mailing list