[vlc-devel] [PATCH 12/20] mkv: replaced manual memory-management with `std::vector` in `matroska_segment_c`

Filip Roséen filip at videolabs.io
Fri Mar 4 18:41:27 CET 2016

The patch in the previous email is an older one that somehow snuck in from the
wrong branch, see the attachment on this email for the one that should be

It is a little bit cleaner and fixes one potential out-of-bounds (by introducing
an if-statement), and another seeking bug if one is seeking close to the end.


On 16/03/04 17:04, Filip Roséen wrote:

> Manually managing memory comes at a cost of both maintainability (in
> terms of safety) and performance, as such I have replaced `p_indexes`
> with a `std::vector` with equivalent functionality.
> Three helper member-functions have been introduced in order to clean up
> the usage of the functionality, as well as removal of two now obsolete
> member-variables. A `typedef` has also been introduced to aid future
> development.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160304/d1e12864/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-mkv-replaced-manual-memory-management-with-std-vecto.patch
Type: text/x-diff
Size: 16265 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160304/d1e12864/attachment.patch>

More information about the vlc-devel mailing list