[vlc-devel] [PATCH v1 1/3] decoder: Always show forced pictures, even during preroll

[Jean-Baptiste Kempf]

I'm really un-ease with that patch.
If we are in pre-roll, why should we display anything?

On 03 Mar, Michael Tänzer wrote :
> If a picture has b_force set it is expected to be shown until the next
> image is decoded. If we are in the preroll and don't show forced pictures
> there might not be a picture when the preroll is finished.
> ---
>  src/input/decoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/input/decoder.c b/src/input/decoder.c
> index a1d7414..b66c885 100644
> --- a/src/input/decoder.c
> +++ b/src/input/decoder.c
> @@ -835,7 +835,7 @@ static int DecoderPlayVideo( decoder_t *p_dec, picture_t *p_picture,
>      bool prerolled;
>  
>      vlc_mutex_lock( &p_owner->lock );
> -    if( p_owner->i_preroll_end > p_picture->date )
> +    if( !p_picture->b_force && p_owner->i_preroll_end > p_picture->date )
>      {
>          vlc_mutex_unlock( &p_owner->lock );
>          picture_Release( p_picture );
> -- 
> 2.5.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-- 
With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device