[vlc-devel] [PATCH] qt: prevent setMinimalView() from sizing incorrectly on fullscreen exit

[Darrell Walisser]

On Mon, Mar 7, 2016 at 8:30 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:

> On 28 Feb, Darrell Walisser wrote :
> > +        /* The original widget width() and height() won't be realized
> > +         * immediately (maybe a bug in Qt). Using a timer won't
> > +         * work because it is unknown how long this could take.*/
> > +         while (fullScreenSize == size())
>
> This is really too ugly.
>
>
Yes, it's ugly, but it is working around a bug in Qt, and a more serious
issue with the UI. There is the windowStateChanged() signal/event in Qt but
I bet it has the same problem.

I did not describe the issue this is trying to address. Which is, if you
have minimal mode disabled, and then go fullscreen, when you come out of
fullscreen, the window size will be the size of the screen instead of what
it started at. The reason is because setMinimalView used the wrong window
size because it hasn't updated yet (due to qt bug).

The alternative is to add much more code, it seems. One idea, keep track of
window size ourselves and maybe roll our own fullscreen code. Easier to
remove the height adjustment patch to setMinimalView() since it is what
introduced the problem.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160307/2ee7531c/attachment.html>