[vlc-devel] [PATCH] avahi: remove useless avahi_threaded_poll_stop() from error path

[Petri Hintukainen]

Error path is never triggered after avahi_threaded_poll_start().
Even if it was, thread should probably be stopped before freeing avahi client ... ?
---
 modules/services_discovery/avahi.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/modules/services_discovery/avahi.c b/modules/services_discovery/avahi.c
index cff96de..9e6bab8 100644
--- a/modules/services_discovery/avahi.c
+++ b/modules/services_discovery/avahi.c
@@ -315,10 +315,7 @@ error:
     if( p_sys->client != NULL )
         avahi_client_free( p_sys->client );
     if( p_sys->poll != NULL )
-    {
-        avahi_threaded_poll_stop( p_sys->poll );
         avahi_threaded_poll_free( p_sys->poll );
-    }
 
     vlc_dictionary_clear( &p_sys->services_name_to_input_item, NULL, NULL );
     free( p_sys );
-- 
2.5.0