[vlc-devel] [PATCH 0/5] mkv: introduced EbmlTypeDispatcher

Filip Roséen filip at videolabs.io
Tue Mar 8 15:11:52 CET 2016

All of these patches are related to a new way of handling pointers to
EbmlElements where the referred to object needs some processing dependent on
the dynamic type of said object.

A reply to this cover-letter will include a explanation of how the code in
dispatcher.hpp works, and the commits in this patch-batch also provides some
explanation (together with comments in the code itself).

A later patch-batch will include the usage of a StringDispatcher, following
the same semantics as the EbmlTypeDispatcher (which is why the contents of
dispatcher.hpp is not in Ebml_dispatcher.hpp).

All the best,

Filip Roséen (5):
  mkv: Added EbmlTypeDispatcher (including changes to Makefile.am)
  mkv: Use EbmTypeDispatcher in `matroska_segment_c::{ParseTrackEntry,ParseTracks}`
  mkv: Cleaned up code to issue debug diagnostics
  mkv: Use EbmlTypeDispatcher in `matroska_segment_c::ParseInfo`
  mkv: use EbmlTypeDispatcher in matroska_segment_c::BlockGet

 modules/demux/Makefile.am                    |   2 +
 modules/demux/mkv/Ebml_dispatcher.hpp        | 161 +++++
 modules/demux/mkv/dispatcher.hpp             | 156 +++++
 modules/demux/mkv/matroska_segment.cpp       | 305 ++++++----
 modules/demux/mkv/matroska_segment_parse.cpp | 842 ++++++++++++---------------
 5 files changed, 880 insertions(+), 586 deletions(-)
 create mode 100644 modules/demux/mkv/Ebml_dispatcher.hpp
 create mode 100644 modules/demux/mkv/dispatcher.hpp


More information about the vlc-devel mailing list