[vlc-devel] [PATCH] sftp: add public key authentication

[Petri Hintukainen]

On ti, 2016-03-08 at 16:26 +0100, Jean-Baptiste Kempf wrote:
> On 08 Mar, Petri Hintukainen wrote :
> > +    if( asprintf( &psz_keyfile1, "%s/.ssh/id_rsa.pub", psz_home )
> > == -1 ||
> > +        asprintf( &psz_keyfile2, "%s/.ssh/id_rsa",     psz_home )
> > == -1 )
> > +        goto bailout;
> 
> How does that behaves on non-POSIX systems, like Windows?

I don't know where ssh keys should be stored in windows. If I copy the
files to C:\users\***\My Documents\.ssh\ , it seems to work just well.

Maybe key file location could be configurable option. Currently only
default key file is used, so this won't work if the user wants to use
alternative key.

Another option could be trying all keys from .ssh/ , but this leads to
authentication failure when key count exceeds server retry limit.

Other limitations:
 - password protected keys won't work
 - .ssh/config (key selection based on host name) is not used

Anyway, I don't expect this feature to gain huge user base (there are
several other bugs/limitations in sftp plugin, and still nobody
complained about those).


- Petri