[vlc-devel] [PATCH] input: subtitles: Added support for detecting external subtitle files on network shares

[Jean-Baptiste Kempf]

Hello Benjamin,

The subject is a bit more complex than it seems, to be honest.

You should talk to Thomas Guillem on IRC, he's been doing half of the
work for this complex issue already.


On 09 Mar, Benjamin Adolphi wrote :
> Ok, so I can move the detection of remote subtitles into another
> thread. And there is probably a way to deactivate dialogs for this
> kind of access? Or do you think that the whole idea of implementing
> this kind of feature is flawed?
> 
> On Wed, Mar 9, 2016 at 10:19 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> > Le 2016-03-09 22:52, Benjamin Adolphi a écrit :
> >>
> >> Thanks for the feedback. I can implement this so that it will
> >> differentiate between local and remote files and keep the old
> >> behaviour for local files. But what do you mean by "setup delays for
> >> remote files"?
> >
> >
> > Network is slow, or it can be. Sometimes very slow or infinitely slow even.
> > We cannot block the input thread or the UI thread just to check that some
> > remote subtitle file exists.
> >
> > Not to mention that some people will rightfully complain about dialogs
> > and/or unsolicited server-side errors.
> >
> >
> > --
> > Rémi Denis-Courmont
> > http://www.remlab.net/
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-- 
With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device