[vlc-devel] [PATCH 1/1] If the target libc lacks strerror_l, fallback to strerror_r.

[Rémi Denis-Courmont]

Le 2016-03-14 05:15, Richard Diamond a écrit :
> On Sun, Mar 13, 2016 at 9:47 PM, Rémi Denis-Courmont <remi at remlab.net
> [1]> wrote:
>
>> Did you actually test this?!
>
> Yes (and again after getting your reply to be sure). Also note that
> the version of `strerror_r` that returns a char* is GNU which is
> allowed to (and does) return a static char*, thus ignoring __buf (the
> NULL param).

glibc has strerror_l(). Adding a glibc-specific fallback here makes no 
sense (and will make it look like we only care about GNU/Linux).

Besides, this does not look thread-safe at all.

-- 
Rémi Denis-Courmont
http://www.remlab.net/