[vlc-devel] atomic_fetch_add for refcounting harmful ?

Rémi Denis-Courmont remi at remlab.net
Wed Mar 16 17:58:15 CET 2016


Le 2016-03-16 10:37, Francois Cartegnie a écrit :
> Hi,
>
> We use atomic_* functions for refcounting, (input_item_Hold)
> and I believe we somehow suffer the same issue as CVE2016_0728
> as atomic_fetch_add does not provide any way to check for overflow
> before adding.

If your code needs more than UINTPTR_MAX references to one single 
object within a single process, your code is broken. I fail to see a 
problem with the reference counting mechanism here.

-- 
Rémi Denis-Courmont
http://www.remlab.net/


More information about the vlc-devel mailing list