[vlc-devel] [PATCH 1/3] mkv: do not reset the i_start_time after a seek was initiated

[Steve Lhomme]

On Thu, Mar 17, 2016 at 5:32 PM, Denis Charmet <typx at dinauz.org> wrote:
> Beware if the chapter doesn't stat exactly on a key frame, you might end up
> with a funny infinite loop.

OK, but I'm not sure if you're referring to this patch. I had to move
this line because, if the call above does a seek on it's own, it will
also set i_start_pts. So We end up with the right value that should be
used.

> On 2016-03-17 15:05, Steve Lhomme wrote:
>>
>> ---
>>  modules/demux/mkv/virtual_segment.cpp | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/modules/demux/mkv/virtual_segment.cpp
>> b/modules/demux/mkv/virtual_segment.cpp
>> index 6d909d1..90050fc 100644
>> --- a/modules/demux/mkv/virtual_segment.cpp
>> +++ b/modules/demux/mkv/virtual_segment.cpp
>> @@ -459,8 +459,8 @@ bool virtual_segment_c::UpdateCurrentToChapter(
>> demux_t & demux )
>>                          Seek( demux,
>> p_cur_vchapter->i_mk_virtual_start_time, p_cur_vchapter, -1 );
>>                          return true;
>>                      }
>> +                    sys.i_start_pts =
>> p_cur_vchapter->i_mk_virtual_start_time + VLC_TS_0;
>>                  }
>> -                sys.i_start_pts =
>> p_cur_vchapter->i_mk_virtual_start_time + VLC_TS_0;
>>              }
>>
>>              p_current_vchapter = p_cur_vchapter;
>
>
> Regards,
> --
> Denis Charmet - TypX
> Le mauvais esprit est un art de vivre
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel