[vlc-devel] [PATCH 2/2] fix for #15713, checked for i_type, if i_type is ITEM_TYPE_DIRECTORY notification "Now Playing" is not displayed

[Avani Sharma]

 Jean-Baptiste,

Could you please help in knowing which of the following item types should
be ignored for "Now Playing" Notification.

 ITEM_TYPE_UNKNOWN,
 ITEM_TYPE_FILE,
 ITEM_TYPE_DIRECTORY,
 ITEM_TYPE_DISC,
 ITEM_TYPE_CARD,
 ITEM_TYPE_STREAM,
 ITEM_TYPE_PLAYLIST,
 ITEM_TYPE_NODE,

/* This one is not a real type but the number of input_item types. */
ITEM_TYPE_NUMBER

As of now I Know Directory, playlist must be ignored. I checked for stream
and it displays two notifications back to back, one with url  which is not
required and other with title of song (required). DISC (DVDS, Blu-ray,
etc), CARD and NODE I was not able to test. Kindly suggest me on this issue.

Avani

On Fri, Mar 18, 2016 at 10:48 PM, Avani Sharma <avaninith at gmail.com> wrote:

> Yeah sure jb :). I would like to explore this.
>
> Avani
>
> On Fri, Mar 18, 2016 at 5:02 AM, Jean-Baptiste Kempf <jb at videolan.org>
> wrote:
>
>> On 18 Mar, Avani Sharma wrote :
>> > ---
>> >  modules/notify/notify.c | 6 ++++++
>> >  1 file changed, 6 insertions(+)
>> >
>> > diff --git a/modules/notify/notify.c b/modules/notify/notify.c
>> > index adc6de2..1fe1eb3 100644
>> > --- a/modules/notify/notify.c
>> > +++ b/modules/notify/notify.c
>> > @@ -170,10 +170,16 @@ static int ItemChange( vlc_object_t *p_this, const
>> > char *psz_var,
>> >      if( !p_input )
>> >          return VLC_SUCCESS;
>> >
>> > +
>>
>> Unneeded.
>>
>> >      /* Playing something ... */
>> >      input_item_t *p_input_item = input_GetItem( p_input );
>> >      psz_title = input_item_GetTitleFbName( p_input_item );
>> >
>> > +    /* Checking for click on directories */
>> > +    if(p_input_item->i_type == ITEM_TYPE_DIRECTORY){
>> > +        return VLC_SUCCESS;
>> > +    }
>>
>> Way better! Maybe there are other ITEM_TYPE we should ignore, don'tyou
>> thinkg?
>>
>> -
>> With my kindest regards,
>>
>> --
>> Jean-Baptiste Kempf
>> http://www.jbkempf.com/ - +33 672 704 734
>> Sent from my Electronic Device
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160319/6c3da911/attachment.html>