[vlc-devel] [PATCH 2/2] fix for #15713, checked for i_type, if i_type is ITEM_TYPE_DIRECTORY notification "Now Playing" is not displayed

Avani Sharma avaninith at gmail.com
Mon Mar 28 15:58:05 CEST 2016


 Now playing notification turned off for other types also as
 suggested by jb

---
 modules/notify/notify.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/modules/notify/notify.c b/modules/notify/notify.c
index adc6de2..5049e00 100644
--- a/modules/notify/notify.c
+++ b/modules/notify/notify.c
@@ -174,6 +174,13 @@ static int ItemChange( vlc_object_t *p_this, const
char *psz_var,
     input_item_t *p_input_item = input_GetItem( p_input );
     psz_title = input_item_GetTitleFbName( p_input_item );

+    /* Checking for click on directories */
+    if(p_input_item->i_type == ITEM_TYPE_DIRECTORY || p_input_item->i_type
== ITEM_TYPE_PLAYLIST
+        || p_input_item->i_type == ITEM_TYPE_NODE || p_input_item->i_type
== ITEM_TYPE_UNKNOWN
+        || p_input_item->i_type == ITEM_TYPE_CARD){
+        return VLC_SUCCESS;
+    }
+
     /* We need at least a title */
     if( EMPTY_STR( psz_title ) )
     {
-- 
2.1.4


On Fri, Mar 25, 2016 at 1:26 PM, Jean-Baptiste Kempf <jb at videolan.org>
wrote:

> On 19 Mar, Avani Sharma wrote :
> > Could you please help in knowing which of the following item types should
> > be ignored for "Now Playing" Notification.
>
> OK.
>
> >  ITEM_TYPE_UNKNOWN,
> >  ITEM_TYPE_DIRECTORY,
> >  ITEM_TYPE_CARD,
> >  ITEM_TYPE_PLAYLIST,
> >  ITEM_TYPE_NODE,
>
> All those.
>
> With my kindest regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160328/6920a1af/attachment.html>


More information about the vlc-devel mailing list