[vlc-devel] [vlc-commits] Contribs: lua, remove unneeded patch

[Ludovic Fauvet]

On Fri, Mar 25, 2016, at 12:50, Rémi Denis-Courmont wrote:
> On Friday 25 March 2016 11:38:50 Ludovic Fauvet wrote:
> > > Looks to me that sizeof (size_t) is part of the Lua 5.3 ABI...
> > 
> > Yes it does, but given that it doesn't change the bytecode in the end
> 
> - The ABI depends on the value of sizeof (size_t).
> - The byte code is identical on 32-bits and 64-bits architectures.
> 
> So you´re saying that sizeof (size_t) is always the same?

Of course not. I just mean that standard 32/64-bit rules will apply and
there's no need to artificially restrict the interpreter to 32-bit word
size like we did (for a good reason) before.

Speaking of the ABI, since the interpreter will be compiled for the same
target arch as the core, the sizeof(size_t) are supposed to match that
architecture: 32-bit on 32-bit systems and 64-bit on 64-bit systems.

Or I just don't see your point.

But this still leaves one issue: pre-compiling plugins for a different
target endianness is not supported. Therefore I wonder if it wouldn't be
better to only ship the plugins sources + luac and pre-compile them
during the installation (or first run of VLC) but that's another
problem.

-- 
Ludovic Fauvet
www.videolan.org