[vlc-devel] [PATCH 01/11] ogg: don't call pf_demux() directly

[Rémi Denis-Courmont]

Le 2016-05-02 19:45, Steve Lhomme a écrit :
> On Mon, May 2, 2016 at 6:59 PM, Rémi Denis-Courmont <remi at remlab.net> 
> wrote:
>> Le 2016-05-02 18:24, Steve Lhomme a écrit :
>>>
>>> ---
>>>  modules/demux/ogg.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/modules/demux/ogg.c b/modules/demux/ogg.c
>>> index 40b26c6..8b47e86 100644
>>> --- a/modules/demux/ogg.c
>>> +++ b/modules/demux/ogg.c
>>> @@ -246,7 +246,7 @@ static int Open( vlc_object_t * p_this )
>>>      TAB_INIT( p_sys->i_seekpoints, p_sys->pp_seekpoints );
>>>
>>>
>>> -    while ( !p_sys->b_preparsing_done && p_demux->pf_demux( 
>>> p_demux ) > 0
>>> )
>>> +    while ( !p_sys->b_preparsing_done && demux_Demux( p_demux ) > 
>>> 0 )
>>
>>
>> This patch itself looks OK, but something is wrong if you depend on 
>> it.
>
> Yes, the problem is the way a lot of the code is using demuxers.

Yes, you should obviously not change the programming interface of demux 
and access_demux plugins.

But that's completely orthogonal since you are adding a new plugin 
type.

-- 
Rémi Denis-Courmont
http://www.remlab.net/