[vlc-devel] [PATCH 09/34] mkv: removed unnecessary data-member i_start_pos from matroska_segment_c

Filip Roséen filip at videolabs.io
Fri May 6 19:08:48 CEST 2016


This variable is of no real aid, as such it has been removed to favor
readability. The less fuzz around what we actually need, the better.
---
 modules/demux/mkv/matroska_segment.cpp | 3 +--
 modules/demux/mkv/matroska_segment.hpp | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/modules/demux/mkv/matroska_segment.cpp b/modules/demux/mkv/matroska_segment.cpp
index 5d34ec3..a211d3d 100644
--- a/modules/demux/mkv/matroska_segment.cpp
+++ b/modules/demux/mkv/matroska_segment.cpp
@@ -47,7 +47,6 @@ matroska_segment_c::matroska_segment_c( demux_sys_t & demuxer, EbmlStream & estr
     ,cluster(NULL)
     ,i_block_pos(0)
     ,i_cluster_pos(0)
-    ,i_start_pos(0)
     ,p_segment_uid(NULL)
     ,p_prev_segment_uid(NULL)
     ,p_next_segment_uid(NULL)
@@ -584,7 +583,7 @@ bool matroska_segment_c::Preload( )
 
             cluster = kc_ptr;
 
-            i_cluster_pos = i_start_pos = cluster->GetElementPosition();
+            i_cluster_pos = cluster->GetElementPosition();
             ParseCluster( cluster );
 
             ep->Down();
diff --git a/modules/demux/mkv/matroska_segment.hpp b/modules/demux/mkv/matroska_segment.hpp
index e86c1af..8b9d569 100644
--- a/modules/demux/mkv/matroska_segment.hpp
+++ b/modules/demux/mkv/matroska_segment.hpp
@@ -102,7 +102,6 @@ public:
     KaxCluster              *cluster;
     uint64                  i_block_pos;
     uint64                  i_cluster_pos;
-    int64_t                 i_start_pos;
     KaxSegmentUID           *p_segment_uid;
     KaxPrevUID              *p_prev_segment_uid;
     KaxNextUID              *p_next_segment_uid;
-- 
2.8.2



More information about the vlc-devel mailing list