[vlc-devel] [PATCH 00/30] Resubmit of previous mkv-patch-batch

Filip Roséen filip at videolabs.io
Mon May 9 14:52:54 CEST 2016

This patch-batch includes a few more patches that fixes minor issues that was
discovered during a massive rebase of the previous patch batch.

J-B noticed that some of the previous commits resulted in compile errors midway
through the batch, meaning that a bisect would end up killing the build of vlc.
In order to fix this issue some commits;
    - have been reordered,
    - been refactored,
    - joined into bigger commits.

Filip Roséen (30):
  mkv: removed unused/unnecessary argument to functions involved in seek
  mkv: removed unnecessary data-member i_start_pos from matroska_segment_c
  mkv: removed code dealing with KaxClusterSilentTrackNumber
  mkv: fixup of removal of code related to SilentTrack
  mkv: removed manual memory management from mkv_track_t
  mkv: introduced matroska_segment_c::PreloadClusters
  mkv: added call to IndexAppendCluster in matroska_segment_c::Preload
  mkv: removed legacy seeking
  mkv: removed legacy indexing
  mkv: replaced usage of std::vector with std::map (matroska_segment_c::tracks)
  mkv: removed unnecessary call to es_out_Control
  mkv: renamed matroska_segment_c::{Select,UnSelect}
  mkv: cleaned matroska_segment_c::LoadCues
  mkv: cleanup of matroska_segment_c::ParseTrackEntry
  mkv: added matroska_segment_seeker.{hpp,cpp}
  mkv: create index points using matroska_segment_seeker.{hpp,cpp}
  mkv: add every seen subtitle block as seekpoint
  mkv: fix matroska_segment_c::ParseCluster to use new functionality
  mkv: removed unnecessary diagnostic and branching
  mkv: set p_sys->i_pts in a little bit cleaner way
  mkv: support "inprecise seeking" (ie. "Fast Seek")
  mkv: added new seek-implementation
  mkv: skip decoding of blocks that are not necessary
  mkv: fixed used after free of matroska_segment_c::ep
  mkv: removed matroska_segment_c::i_cluster_pos
  mkv: removed EbmlParser::UnGet
  mkv: removed unnecessary complexity in Ebml_parser.cpp
  mkv: whitespace cleaning + correcting header includes
  mkv: removed code that would make us loop ordered chapters forever
  mkv: fixed format-specifier related to mkv_track_t::i_number

 modules/demux/Makefile.am                     |   1 +
 modules/demux/mkv/Ebml_parser.cpp             |  49 +--
 modules/demux/mkv/Ebml_parser.hpp             |   1 -
 modules/demux/mkv/chapter_command.cpp         |   2 +-
 modules/demux/mkv/demux.cpp                   |   9 +-
 modules/demux/mkv/matroska_segment.cpp        | 573 ++++++++++----------------
 modules/demux/mkv/matroska_segment.hpp        |  33 +-
 modules/demux/mkv/matroska_segment_parse.cpp  | 153 ++++---
 modules/demux/mkv/matroska_segment_seeker.cpp | 405 ++++++++++++++++++
 modules/demux/mkv/matroska_segment_seeker.hpp | 103 +++++
 modules/demux/mkv/mkv.cpp                     | 233 ++++++-----
 modules/demux/mkv/mkv.hpp                     | 100 ++---
 modules/demux/mkv/util.cpp                    |   9 +-
 modules/demux/mkv/virtual_segment.cpp         | 108 ++---
 modules/demux/mkv/virtual_segment.hpp         |   3 +-
 15 files changed, 1070 insertions(+), 712 deletions(-)
 create mode 100644 modules/demux/mkv/matroska_segment_seeker.cpp
 create mode 100644 modules/demux/mkv/matroska_segment_seeker.hpp


More information about the vlc-devel mailing list