[vlc-devel] [PATCH] mkv: fix broken playback of V_VP9 in webm/mkv

[Filip Roséen]

>From my tests this weekend playback was broken in ffmpeg (and libav, just for the record) no matter if the patch was applied or not - but I will do further experimentation this week.

Applying the patch makes modules/codec/vpx.c be able to do proper playback. Though I will need to double-check so that there isn't a problem with my setup.

Sent from my BlackBerry 10 smartphone.
  Original Message  
From: Denis Charmet
Sent: Tuesday, May 17, 2016 10:26 AM
To: Mailing list for VLC media player developers
Reply To: Mailing list for VLC media player developers
Subject: Re: [vlc-devel]	[PATCH] mkv: fix broken playback of V_VP9 in webm/mkv

Hi,

On 2016-05-13 19:23, Filip Roséen wrote:
> close #16936
> ---
> modules/demux/mkv/matroska_segment_parse.cpp | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/modules/demux/mkv/matroska_segment_parse.cpp
> b/modules/demux/mkv/matroska_segment_parse.cpp
> index 413bd16..5ad4db1 100644
> --- a/modules/demux/mkv/matroska_segment_parse.cpp
> +++ b/modules/demux/mkv/matroska_segment_parse.cpp
> @@ -1321,7 +1321,6 @@ int32_t matroska_segment_c::TrackInit(
> mkv_track_t * p_tk )
> }
> S_CASE("V_VP9") {
> vars.p_fmt->i_codec = VLC_CODEC_VP9;
> - vars.p_fmt->b_packetized = false;

If you do that you will break the decoding by ffmpeg's lavc since it 
expects frame already packetized by avparser.

> vars.p_tk->b_pts_only = true;
> 
> fill_extra_data( vars.p_tk, 0 );

Regards,
-- 
Denis Charmet - TypX
Le mauvais esprit est un art de vivre
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel