[vlc-devel] [RFC-PATCH] include: add variables to video_format_t for 360 videos

[Emeric Grange]

Hi,
I second this proposition, however:

On 19/05/16 16:41, "vlc-devel on behalf of Adrien Maglo" <vlc-devel-bounces at videolan.org on behalf of magsoft at videolan.org> wrote:

>---
> include/vlc_es.h | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
>diff --git a/include/vlc_es.h b/include/vlc_es.h
>index 9c0feb9..d1ebe3a 100644
>--- a/include/vlc_es.h
>+++ b/include/vlc_es.h
>@@ -244,6 +244,16 @@ typedef enum video_chroma_location_t
> } video_chroma_location_t;
> 
> /**
>+ * Video projection mode.
>+ */
>+typedef enum video_projection_mode_t
>+{
>+    PROJECTION_MODE_RECTANGLE = 0,
>+    PROJECTION_MODE_CUBE,
>+    PROJECTION_MODE_SPHERE,
>+} video_projection_mode_t;

This should say equirectangular and cubemap.

>+/**
>  * video format description
>  */
> struct video_format_t
>@@ -276,6 +286,11 @@ struct video_format_t
>     video_color_space_t space;                        /**< YCbCr color space */
>     bool b_color_range_full;                    /**< 0-255 instead of 16-235 */
>     video_chroma_location_t chroma_location;      /**< YCbCr chroma location */
>+
>+    video_projection_mode_t projection_mode;            /**< projection mode */
>+    int pose_yaw_degrees;                        /**< initial view point yaw */
>+    int pose_pitch_degrees;                    /**< initial view point pitch */
>+    int pose_roll_degrees;                      /**< initial view point roll */
> };

I think you should plan ahead and also set the layout and padding infos from the cubemap projection.

> /**
>-- 
>2.5.0
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel