[vlc-devel] [PATCH 1/4] include: add variables to video_format_t for 360 videos

[Rémi Denis-Courmont]

Le 2016-05-23 11:53, Adrien Maglo a écrit :
> ---
>  include/vlc_es.h | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/include/vlc_es.h b/include/vlc_es.h
> index 9c0feb9..1fe0ca3 100644
> --- a/include/vlc_es.h
> +++ b/include/vlc_es.h
> @@ -244,6 +244,16 @@ typedef enum video_chroma_location_t
>  } video_chroma_location_t;
>
>  /**
> + * Video projection mode.
> + */
> +typedef enum video_projection_mode_t
> +{
> +    PROJECTION_MODE_RECTANGULAR = 0,
> +    PROJECTION_MODE_CUBEMAP,
> +    PROJECTION_MODE_EQUIRECTANGULAR,
> +} video_projection_mode_t;
> +
> +/**
>   * video format description
>   */
>  struct video_format_t
> @@ -276,6 +286,13 @@ struct video_format_t
>      video_color_space_t space;                        /**< YCbCr
> color space */
>      bool b_color_range_full;                    /**< 0-255 instead
> of 16-235 */
>      video_chroma_location_t chroma_location;      /**< YCbCr chroma
> location */
> +
> +    video_projection_mode_t projection_mode;            /**<
> projection mode */
> +    int i_pose_yaw_degrees;                      /**< initial view
> point yaw */
> +    int i_pose_pitch_degrees;                  /**< initial view
> point pitch */
> +    int i_pose_roll_degrees;                    /**< initial view
> point roll */
> +    int i_cubemap_layout;                  /**< layout of the cube
> map faces */
> +    int i_cubemap_padding;      /**< padding in pixels of the cube
> map faces */
>  };

Using int for degree angles is bizarre. At the very least, this is not 
sufficiently well documented.

>
>  /**

-- 
Rémi Denis-Courmont
http://www.remlab.net/