[vlc-devel] [PATCH 1/4] include: add variables to video_format_t for 360 videos

Filip Roséen filip at videolabs.io
Mon May 23 14:04:26 CEST 2016

Given that google propose that the relevant data-members are fixed-point values 16.16 (ie. stored as 32-bit integers), adding a comment about such and changing the type from int to uint32_t might be more appropriate (given that int is not guaranteed to be 32 bits, and even if it is; the highest-bit would be to denote signedness).

uint_least32_t is another appropriate type, if one want to be over-pedantic (given that a larger type certainly would not cause any harm).

  Original Message  
From: Adrien Maglo
Sent: Monday, May 23, 2016 12:19 PM
To: vlc-devel at videolan.org
Reply To: Mailing list for VLC media player developers
Subject: Re: [vlc-devel] [PATCH 1/4] include: add variables to video_format_t for 360 videos

Le 23/05/2016 12:05, Rémi Denis-Courmont a écrit :
> Using int for degree angles is bizarre. At the very least, this is not
> sufficiently well documented.

Storing degree angles in integers may be bizarre. Nevertheless, this is 
how Google proposes to store them in their spec for mp4.

Would you prefer storing them as float?

Best regards,


vlc-devel mailing list
To unsubscribe or modify your subscription options:

More information about the vlc-devel mailing list