[vlc-devel] [PATCH 1/2] vlc_url_t: Add a b_ipv6 field

[Rémi Denis-Courmont]

Le 2016-05-23 14:14, Hugo Beauzée-Luyssen a écrit :
> On 05/23/2016 02:02 PM, Rémi Denis-Courmont wrote:
>> Le 2016-05-23 13:59, Hugo Beauzée-Luyssen a écrit :
>>> ---
>>>  include/vlc_url.h | 1 +
>>>  src/text/url.c    | 2 ++
>>>  2 files changed, 3 insertions(+)
>>
>> There are no "is this IPv6" field on URL schemes. In most cases, it 
>> is
>> either meaningless or unspecified anyway.
>>
>> So no thanks.
>>
>
> The goal here is to avoid losing the information provided by the
> square brackets.

The entropy of the brackets is zero, since the formats allowed within 
brackets, and without brackets do not overlap.

And in any case, confusing name will lead to confused usage, will lead 
to more bugs. Case in point: we do decode/post-process the hostname, and 
your proposal ostensibly ignores that, already introducing bugs.

-- 
Rémi Denis-Courmont
http://www.remlab.net/