[vlc-devel] [PATCH 2/3] input/decoder.c: fixed code-duplication

Filip Roséen filip at videolabs.io
Mon May 23 19:51:42 CEST 2016

> On Monday 23 May 2016 17:45:27 Filip Roséen wrote:
> > Attached is a patch that circumvents any potential issue by giving
> > DecoderDispatchBlock a new argument named `b_do_cc` which simply toggles any
> > potential invocation of `DecoderGetCc` on/off.
> So the goal was to simplify, and it ends up making things more intricate...

That was my fear, hence the wording in a previous message (stating that it might
not be worth-while "simplifying" the implementation if it turns out that such
"simplification" adds complexity).

If it is somehow safe to assume that `p_packetizer->pf_get_cc` is always NULL
for packetizers that deals with audio, or that it is actually safe having such
callback invoked (for audio); then the patch in the below linked message applies:

  - https://mailman.videolan.org/pipermail/vlc-devel/2016-May/107840.html

Since I am unable to answer this question on my own, any help on the matter is

> Please, no. Do it properly, or don´t do it.

I whole-heartedly agree, thanks.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160523/e21f19b5/attachment.html>

More information about the vlc-devel mailing list