[vlc-devel] [PATCH v3] Add support for GoPro HiLight tags as chapters

[Jean-Baptiste Kempf]

On 24 May, Emeric Grange wrote :
> +static void LoadChapterGoPro( demux_t *p_demux, MP4_Box_t *p_hmmt )
> +{
> +    demux_sys_t *p_sys = p_demux->p_sys;
> +
> +    p_sys->p_title = vlc_input_title_New();
> +    for( unsigned i = 0; i < BOXDATA(p_hmmt)->i_chapter_count; i++ )
> +    {
> +        seekpoint_t *s = vlc_seekpoint_New();
> +        if (s)
> +        {
> +            asprintf( &s->psz_name, "HiLight tag #%u", i+1 );

Shouldn't you check asprintf return before calling EnsureUTF8?

Rest is good :)

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device