[vlc-devel] [PATCH v3] Add support for GoPro HiLight tags as chapters

Filip Roséen filip at videolabs.io
Wed May 25 02:48:38 CEST 2016

On 16/05/25 02:42, Filip Roséen wrote:

> See [this testcase](http://codepad.org/gTFDYk8G), or the attached file, for a
> simulation of the above. Given that the expression `p_hmmt->i_chapter_count*4`
> might result in a value that will overflow, the if-statement itself is faulty.
> Disclaimer
> ----------
>  - *I am currently insanely tired and just skimmed the patch in this thread
>    while having a smoke, I in no way claim that I am fit for fight for reviews
>    at this hour.*

And now I just noticed that `testcase.c` (the attached file) and the linked code
should of course have declared `i_read` as `int64_t` (not `uint64_t`); but it
will not change the fact that the relevant expression (mentioned earlier) could

obviously it is time to get some sleep! :-)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160525/22a19d51/attachment.html>

More information about the vlc-devel mailing list