[vlc-devel] [RFC PATCH] playlist: don't open failing items in loop

Thomas Guillem thomas at gllm.fr
Wed May 25 10:34:22 CEST 2016

On Tue, May 24, 2016, at 13:00, Rémi Denis-Courmont wrote:
> Le 2016-05-24 11:09, Filip Roséen a écrit :
> > One immediate reaction:
> >
> >  	* if we have a playlist set to loop that contains one item which
> > result in ERROR_S, this patch will completely stop the playback - 
> > even
> > if there are other playable items in the list.
> >
> >> If “Repeat All” or “Repeat current Item” option are set. The
> >> same failing item will be opened in loop.
> >
> > This might be what most expect us to do.
> >
> > I do not think that looping items should depend on whether there is 
> > an
> > error when we try to play them, because there is nothing saying that
> > the error will remain next time we try to do it.
> >
> > We should trust that the user knows what it has asked us to do, and
> > even assume that any input that we are asked to play should be played
> > (even if this results in an error). Proving that the underlying
> > bytestream does not change before the next time we theoretically 
> > would
> > have played the item is impossible, and we can also not prove that an
> > access that fails one time, always will fail.
> Yes, exactly.
> And what users complain about is the poor UI handling of high error 
> rates, which renders the UI almost unusable. That issue lies in the GUI.

I don't see how you can handle that in the GUI.
In the playlist, you have all the informations to handle that case.

Actually, my patch was wrong: NextItem stops once it hits an item with
an error.

I have a new patch that just ignore items with an error and go to the
one after.
Indeed, this is done only for the automatic case, user will still be
able to open a failing item manually.

> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list