[vlc-devel] [PATCH 2/2] win32:thread: keep INFINITE condition wait intact

[Rémi Denis-Courmont]

Le 2016-05-26 13:02, Steve Lhomme a écrit :
> ---
>  src/win32/thread.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/win32/thread.c b/src/win32/thread.c
> index 3e942c4..1dbdca6 100644
> --- a/src/win32/thread.c
> +++ b/src/win32/thread.c
> @@ -272,7 +272,7 @@ static int vlc_cond_wait_delay(vlc_cond_t *wait,
> vlc_mutex_t *lock,
>  {
>      if (ms < 0)
>          ms = 0;
> -    if (ms > 0x7fffffff)
> +    if (ms > 0x7fffffff && ms != INFINITE)
>          ms = 0x7fffffff;

What if the requested delay is 4294967295000 microseconds?

>
>      DWORD delay = ms;

Also return value looks wrong, but that's a pre-existing problem.

-- 
Rémi Denis-Courmont
http://www.remlab.net/