[vlc-devel] [PATCHv5 1/3] access: Add satip access module

[Julian Scheel]

On 28.05.16 17:36, Rémi Denis-Courmont wrote:
> On Friday 27 May 2016 21:26:17 Julian Scheel wrote:
>> This module implements a minimal RTSP subset, which is required to support
>> satip servers.
>>
>> Signed-off-by: Julian Scheel <julian at jusst.de>
>> ---
>> Changes in v5:
>>   - Make sure rtsp parser does not access memory outside of string boundaries
>> - Skip leading whitespace in header fields
>>   - Use mdate() based receive loop timeout
>>   - Correctly signal EOF
>>   - Avoid infinite loop if all udp ports are busy
>>
>> Changes in v4:
>>   - Use strok_r for thread safety
>>
>> Changes in v3:
>> - Use strtok for string separation instead of handcrafted parser
>> - Add missing NEWS, POTFILES and MODULES_LIST
>> - Make strings translatable
>> - Shorten description
>> - Optimise variable types (stream_id, udp_port to uint16_t)
>>   - Drop stream_id check
>> - Do not respond to ACCESS_GET_SIZE
>> ---
>>   NEWS                       |   1 +
>>   configure.ac               |   2 +-
>>   modules/MODULES_LIST       |   1 +
>>   modules/access/Makefile.am |   3 +
>>   modules/access/satip.c     | 628
>> +++++++++++++++++++++++++++++++++++++++++++++ po/POTFILES.in             |
>>   1 +
>>   6 files changed, 635 insertions(+), 1 deletion(-)
>>   create mode 100644 modules/access/satip.c
>>
>> diff --git a/NEWS b/NEWS
>> index 9f2c2af..612479d 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -44,6 +44,7 @@ Access:
>>    * Named pipes and device nodes are no longer included in directory
>> listings by default. Use --list-special-files to include them back.
>>    * Support for timeout in UDP input --udp-timeout=<seconds>
>> + * New SAT>IP access module, to receive DVB-S via IP networks
>>
>>   Decoder:
>>    * OMX GPU-zerocopy support for decoding and display on Android using
>> OpenMax IL diff --git a/configure.ac b/configure.ac
>> index c3c65f9..f647b96 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -583,7 +583,7 @@ need_libc=false
>>
>>   dnl Check for usual libc functions
>>   AC_CHECK_DECLS([nanosleep],,,[#include <time.h>])
>> -AC_CHECK_FUNCS([daemon fcntl flock fstatvfs fork getenv getpwuid_r isatty
>> lstat memalign mkostemp mmap open_memstream openat pread posix_fadvise
>> posix_madvise setlocale strerror_l stricmp strnicmp strptime uselocale
>> pthread_cond_timedwait_monotonic_np pthread_condattr_setclock])
>> +AC_CHECK_FUNCS([daemon fcntl flock fstatvfs fork getenv getpwuid_r isatty
>> lstat memalign mkostemp mmap open_memstream openat pread posix_fadvise
>> posix_madvise recvmmsg setlocale strerror_l stricmp strnicmp strptime
>> uselocale pthread_cond_timedwait_monotonic_np pthread_condattr_setclock])
>
> That line is only for standard functions. There is another place for Linux-
> specific calls.

I'll change that.

> Also my previous questions were neither answered nor addressed.

They were answered and most of them addressed, please see yesterdays mail:
https://mailman.videolan.org/pipermail/vlc-devel/2016-May/107921.html

Regarding your concerns about lockup on teardown I asked back, as I 
don't see an issue there so far.

-Julian