[vlc-devel] [RFC PATCH 1/2] include: add variables to video_format_t for 360 videos

[Rémi Denis-Courmont]

On Friday 27 May 2016 15:18:09 Jean-Baptiste Kempf wrote:
> From: Adrien Maglo <magsoft at videolan.org>
> 
> Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>
> ---
>  include/vlc_es.h | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/include/vlc_es.h b/include/vlc_es.h
> index 9c0feb9..2c6fe57 100644
> --- a/include/vlc_es.h
> +++ b/include/vlc_es.h
> @@ -193,6 +193,17 @@ typedef enum video_transform_t
>  } video_transform_t;
> 
>  /**
> + * Video projection mode.
> + */
> +typedef enum video_projection_mode_t
> +{
> +    PROJECTION_MODE_RECTANGULAR = 0,
> +    PROJECTION_MODE_EQUIRECTANGULAR,
> +
> +    PROJECTION_MODE_CUBEMAP_LAYOUT_STANDARD = 0x100,
> +} video_projection_mode_t;
> +
> +/**
>   * Video color primaries (a.k.a. chromacities)
>   */
>  typedef enum video_color_primaries_t
> @@ -276,6 +287,12 @@ struct video_format_t
>      video_color_space_t space;                        /**< YCbCr color
> space */ bool b_color_range_full;                    /**< 0-255 instead of
> 16-235 */ video_chroma_location_t chroma_location;      /**< YCbCr chroma
> location */ +
> +    video_projection_mode_t projection_mode;            /**< projection
> mode */
> +    int32_t i_pose_yaw_degrees;     /**< view point yaw in 16.16
> fixed point */
> +    int32_t i_pose_pitch_degrees; /**< view point pitch in
> 16.16 fixed point */
> +    int32_t i_pose_roll_degrees;   /**< view point
> roll in 16.16 fixed point */
> +    uint32_t i_cubemap_padding; /**< padding
> in pixels of the cube map faces */ };
> 
>  /**

Can´t we use floats? Fixed point is a fine format for storage and interchange, 
but I don´t see the point in here.

Regardless still not clear if the degree range is ]-180.,+180.],
[-180.,+180.[, [0.,360.[ or something funny.

-- 
Rémi Denis-Courmont
http://www.remlab.net/