[vlc-devel] [PATCH 01/10] [RFC] core: add demux-filter objects to intercept & filter demuxer calls

[Rémi Denis-Courmont]

On Tuesday 31 May 2016 19:31:39 Steve Lhomme wrote:
> On Tue, May 31, 2016 at 4:28 PM, Rémi Denis-Courmont <remi at remlab.net> 
wrote:
> > Le 2016-05-31 16:05, Steve Lhomme a écrit :
> >> On Tue, May 31, 2016 at 3:28 PM, Rémi Denis-Courmont <remi at remlab.net>
> >> 
> >> wrote:
> >>> Le 2016-05-31 13:15, Steve Lhomme a écrit :
> >>>> This can be used to tweak the results of some Control() calls or delay
> >>>> the
> >>>> actual Demux() call.
> >>>> 
> >>>> A demuxer filter should call demux_FilterDemuxNext() to call the demux
> >>>> operation to the next demuxer in line and demux_vaFilterControlNext()
> >>>> to
> >>>> pass
> >>>> the control calls to the next demuxer in line.
> >>> 
> >>> No way. I have spent an awful lot of times removing this bug with stream
> >>> filters and access. You don't get to add it back.
> >> 
> >> It is only for demuxer filters. This code did not exist before. All
> >> the other demuxer users continue to work the same.
> > 
> > And? Just like access, stream_filters, and pretty much all plugin types,
> > demuxers are not reentrant.
> 
> What's reentrant about filterA->filterB->demuxer calls ?

The case where you skip the filter(s) and invoke the demuxer directly!

demux_FilterDemuxer() in particular.

-- 
Rémi Denis-Courmont
http://www.remlab.net/