[vlc-devel] [PATCH 1/4] mkv/demux: fix 17567: null-pointer dereference in EnsureDuration

[Rémi Denis-Courmont]

Le 2016-11-02 12:39, Steve Lhomme a écrit :
> On Wed, Nov 2, 2016 at 11:16 AM, Filip Roséen <filip at atch.se> wrote:
>> Hi Steve,
>>
>> Could you provide samples, where the decision to have non-finite 
>> clusters is
>> justifiable, that break with the proposed (and already merged) 
>> changes?
>
> As I said, the already merge change is wrong. Non-finite streams
> should be treated as finite streams when it comes to the duration, so
> long as we know the file end (I suppose STREAM_CAN_FASTSEEK implies
> that).

CAN_SEEK / CAN_FASTSEEK only implies that you can seek. It does not 
imply that the stream length is known or constant.

You can get the stream size with the dedicated accessor, but it is 
purely informational and can change asynchronously.

-- 
Rémi Denis-Courmont
http://www.remlab.net/