[vlc-devel] [PATCH 04/15] opengl: no need to restrict the radian values

[Steve Lhomme]

On Fri, Nov 4, 2016 at 6:16 PM, Filip Roséen <filip at atch.se> wrote:
> Hi Steve,
>
> On 2016-11-04 18:08, Steve Lhomme wrote:
>
>  ---
>   modules/video_output/opengl.c | 6 ------
>   1 file changed, 6 deletions(-)
>
>  diff --git a/modules/video_output/opengl.c b/modules/video_output/opengl.c
>  index aee96bd..3adc31a 100644
>  --- a/modules/video_output/opengl.c
>  +++ b/modules/video_output/opengl.c
>  @@ -784,14 +784,8 @@ void vout_display_opengl_Delete(vout_display_opengl_t
> *vgl)
>   void vout_display_opengl_SetViewpoint(vout_display_opengl_t *vgl, const
> vlc_viewpoint_t *p_viewpoint)
>   {
>       vgl->f_teta = p_viewpoint->f_yaw - M_PI / 2;
>  -    if (vgl->f_teta < -M_PI)
>  -        vgl->f_teta = M_PI;
>       vgl->f_phi = p_viewpoint->f_pitch;
>  -    if (vgl->f_phi < -M_PI / 2)
>  -        vgl->f_phi = -M_PI / 2;
>       vgl->f_roll = p_viewpoint->f_roll;
>  -    if (vgl->f_roll < -M_PI / 2)
>  -        vgl->f_roll = -M_PI / 2;
>   }
>
> git rebase gone wrong?
>
> The above, removed lines, was added in [PATCH 03/15], it would be easier
> following the changes if changes introduced by the individual patches was
> not reverted by a later patch in the patch-batch.

I think these come from the old opengl code and so I kept them while
refactoring the code. Then I actually removed them because they are
not needed.

>   picture_pool_t *vout_display_opengl_GetPool(vout_display_opengl_t *vgl,
> unsigned requested_count)
>  --
>  2.10.1
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel