[vlc-devel] [PATCH 09/15] test: use the jpeg file to test vout specific calls

[Steve Lhomme]

On Fri, Nov 4, 2016 at 6:19 PM, Filip Roséen <filip at atch.se> wrote:
> On 2016-11-04 18:08, Steve Lhomme wrote:
>
>  make sure we use a dummy/portable vout by default in tests.
>  ---
>   test/libvlc/test.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
>  diff --git a/test/libvlc/test.h b/test/libvlc/test.h
>  index 4e8356a..62e260f 100644
>  --- a/test/libvlc/test.h
>  +++ b/test/libvlc/test.h
>  @@ -48,7 +48,7 @@
>    */
>
>   static const char * test_defaults_args[] = {
>  -    "-v",
>  +    "-v", "--vout=vdummy",
>   };
>
>   static const int test_defaults_nargs =
>  @@ -56,6 +56,7 @@ static const int test_defaults_nargs =
>
>   /*static const char test_default_sample[] = "samples/test.sample";*/
>   static const char test_default_sample[] = SRCDIR"/samples/empty.voc";
>  +static const char test_default_video[] = SRCDIR"/samples/image.jpg";
>
> Does it not make more sense to incorporate the addition of this line in
> [PATCH 10/15] (given that is when it is first used)?

I prefer not because 10/15 could be reverted and 09/15 still be usable
for other tests.

>   /*********************************************************************
>  --
>  2.10.1
>
>  _______________________________________________
>  vlc-devel mailing list
>  To unsubscribe or modify your subscription options:
>  https://mailman.videolan.org/listinfo/vlc-devel
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel