[vlc-devel] [PATCH 2/3] vimeo.lua: Improve URL probe function

Pierre Ynard linkfanel at yahoo.fr
Sat Nov 5 02:40:26 CET 2016

Your patch isn't based on the latest version, and it doesn't work at

> Why don’t you just include 'www.' into the match strings, instead
> of gsub-ing away four characters? Rather inefficient (not that it’d
> matter much at this point).

So that both www.vimeo.com and vimeo.com are supported. Currently
www.vimeo.com always redirects to vimeo.com first, but that might change
in the future.

> Then, string.match is overkill here, string.find would do the same
> job.

Code simplicity and readability is more important.

Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."

More information about the vlc-devel mailing list