[vlc-devel] [PATCH 1/3] demux/nsv: improve diagnostics related to unknown codec

Filip Roséen filip at atch.se
Sun Nov 6 03:17:23 CET 2016


It is more helpful to know whether the unsupported codec is video or audio, and
given the seriousness of the matter; an error or is more appropriate than a
warning.

---
 modules/demux/nsv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/demux/nsv.c b/modules/demux/nsv.c
index 2421664..8e4e73d 100644
--- a/modules/demux/nsv.c
+++ b/modules/demux/nsv.c
@@ -512,7 +512,7 @@ static int ReadNSVs( demux_t *p_demux )
         case VLC_FOURCC( 'N', 'O', 'N', 'E' ):
             break;
         default:
-            msg_Warn( p_demux, "unknown codec %4.4s", (char *)&fcc );
+            msg_Err( p_demux, "unsupported video codec %4.4s", (char *)&fcc );
             break;
     }
     if( fcc != VLC_FOURCC( 'N', 'O', 'N', 'E' ) && fcc != p_sys->fmt_video.i_codec  )
@@ -553,7 +553,7 @@ static int ReadNSVs( demux_t *p_demux )
         case VLC_FOURCC( 'N', 'O', 'N', 'E' ):
             break;
         default:
-            msg_Warn( p_demux, "unknown codec %4.4s", (char *)&fcc );
+            msg_Err( p_demux, "unsupported audio codec %4.4s", (char *)&fcc );
             break;
     }
 
-- 
2.10.2



More information about the vlc-devel mailing list